Bug 81000

Summary:

[BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController

Product:

WebKit

Reporter:

Andrew Lo <anlo>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

levin+threading, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch #1	none
Fixed style issues	none

Description Andrew Lo 2012-03-13 09:06:23 PDT

Implement DisplayRefreshMonitor for the BlackBerry port, so that requestAnimationFrame uses the BlackBerry platform AnimationFrameRateController to signal frame changes.

Comment 1 Andrew Lo 2012-03-13 15:04:16 PDT

Created attachment 131721 [details]
patch #1

Comment 2 WebKit Review Bot 2012-03-13 15:08:49 PDT

Attachment 131721 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WebCore/ChangeLog:11:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:77:  The parameter name "monitor" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:78:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andrew Lo 2012-03-13 15:35:02 PDT

Created attachment 131728 [details]
Fixed style issues

Comment 4 WebKit Review Bot 2012-03-14 09:23:17 PDT

Comment on attachment 131728 [details]
Fixed style issues

Clearing flags on attachment: 131728

Committed r110709: <http://trac.webkit.org/changeset/110709>

Comment 5 WebKit Review Bot 2012-03-14 09:23:21 PDT

All reviewed patches have been landed.  Closing bug.