Bug 81000

Summary: [BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
Product: WebKit Reporter: Andrew Lo <anlo>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: levin+threading, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch #1
none
Fixed style issues none

Andrew Lo
Reported 2012-03-13 09:06:23 PDT
Implement DisplayRefreshMonitor for the BlackBerry port, so that requestAnimationFrame uses the BlackBerry platform AnimationFrameRateController to signal frame changes.
Attachments
patch #1 (12.72 KB, patch)
2012-03-13 15:04 PDT, Andrew Lo 		no flags
DetailsFormatted DiffDiff
Fixed style issues (12.77 KB, patch)
2012-03-13 15:35 PDT, Andrew Lo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Lo
Comment 1 2012-03-13 15:04:16 PDT
Created attachment 131721 [details] patch #1
WebKit Review Bot
Comment 2 2012-03-13 15:08:49 PDT
Attachment 131721 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/ChangeLog:11: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:77: The parameter name "monitor" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:78: Missing space inside { }. [whitespace/braces] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrew Lo
Comment 3 2012-03-13 15:35:02 PDT
Created attachment 131728 [details] Fixed style issues
WebKit Review Bot
Comment 4 2012-03-14 09:23:17 PDT
Comment on attachment 131728 [details] Fixed style issues Clearing flags on attachment: 131728 Committed r110709: <http://trac.webkit.org/changeset/110709>
WebKit Review Bot
Comment 5 2012-03-14 09:23:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.