Summary: | r110542: New fast/forms/label/labelable-elements.html fails | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ádám Kallai <kadam> |
Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ap, jberlin, ossy, thorton, tkent, yosin |
Priority: | P2 | Keywords: | LayoutTestFailure, Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 80574 |
Description
Ádám Kallai
2012-03-13 06:56:28 PDT
I skipped this test. http://trac.webkit.org/changeset/110558 Is there some reason why the test should be skipped? We usually land expected failing results unless this is: 1. A feature that is not turned on for your port. 2. DRT/WKTR support for the test doesn't exist for your port. 3. It is crashing or causing crashes in other tests. We should land mac-specific expected failing results for this test, since it is failing on Lion as well as SL: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r110576%20(38036)/fast/forms/label/labelable-elements-pretty-diff.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r110561%20(19017)/fast/forms/label/labelable-elements-pretty-diff.html http://build.webkit.org/results/Lion%20Intel%20Debug%20(Tests)/r110578%20(4409)/fast/forms/label/labelable-elements-pretty-diff.html Might be related to / fixed by the fix for https://bugs.webkit.org/show_bug.cgi?id=80466 Committed the expected failing results for Mac in http://trac.webkit.org/changeset/110614 http://trac.webkit.org/changeset/110947 made: fast/forms/label/labelable-elements-expected.txt: Result for ENABLE_DATALIST platforms platform/chromium/fast/forms/label/labelable-elements-expected.txt: Result for !ENABLE_DATALIST Unskipped in platform/qt/Skipped and platform/gtk/Skipped. (In reply to comment #2) > Is there some reason why the test should be skipped? We usually land expected failing results unless this is: > > 1. A feature that is not turned on for your port. > 2. DRT/WKTR support for the test doesn't exist for your port. > 3. It is crashing or causing crashes in other tests. Historically we don't land expected failing results to platform/qt* automatically. It is better to skip it to paint the bot green and let the author check what happened. It think it is a good way to have a plain text list of failing tests instead of zillion never closed bugzilla bug reports. |