Bug 80983

Summary: Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, gavinp, hausmann, kbalazs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

jochen
Reported 2012-03-13 05:13:13 PDT
Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
Attachments
Patch (3.88 KB, patch)
2012-03-13 05:15 PDT, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-03-13 05:15:35 PDT
Created attachment 131593 [details] Patch
jochen
Comment 2 2012-03-13 05:20:48 PDT
Alexey, can you review this change? During my debugging, I often use WTFGetBacktrace to store backtraces in various objects, and want to print the symbolized stack trace at some later point.
jochen
Comment 3 2012-03-14 01:53:09 PDT
Adding Gavin and Balazs who both wrote that code, and Simon and Darin, who reviewed their changes
Gavin Peters
Comment 4 2012-03-14 04:54:16 PDT
Comment on attachment 131593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131593&action=review I'm not a reviewer, but I like this change. > Source/JavaScriptCore/wtf/Assertions.cpp:-307 > - for (int i = framesToSkip; i < frames; ++i) { Nice to see framesToSkip leave the printing logic.
Balazs Kelemen
Comment 5 2012-03-14 07:11:54 PDT
Seems reasonable to me (although I'm not a reviewer).
WebKit Review Bot
Comment 6 2012-03-19 23:48:34 PDT
Comment on attachment 131593 [details] Patch Clearing flags on attachment: 131593 Committed r111366: <http://trac.webkit.org/changeset/111366>
WebKit Review Bot
Comment 7 2012-03-19 23:48:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.