Bug 80972

Summary: Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, macpherson, menard, mifenton, mxie, rakuco, tkent, tonikitoo, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keishi Hattori
Reported 2012-03-13 00:50:43 PDT
ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_COLOR both exist, so I'm unifying these flags to ENABLE_INPUT_TYPE_COLOR.
Attachments
Patch (55.08 KB, patch)
2012-03-13 05:29 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (58.20 KB, patch)
2012-03-30 02:51 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (58.17 KB, patch)
2012-03-30 04:30 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-03-13 05:29:43 PDT
Created attachment 131595 [details] Patch
Hajime Morrita
Comment 2 2012-03-15 22:57:34 PDT
Comment on attachment 131595 [details] Patch Don't forget updating the Wiki page tkent wrote.
Kent Tamura
Comment 3 2012-03-29 19:10:06 PDT
Comment on attachment 131595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131595&action=review > Source/WebKit/chromium/features.gypi:-55 > - 'ENABLE_INPUT_COLOR=0', Let's add ENABLE_INPUT_TYPE_COLOR=1
Keishi Hattori
Comment 4 2012-03-30 02:51:09 PDT
Created attachment 134757 [details] Patch
Kent Tamura
Comment 5 2012-03-30 02:57:51 PDT
Comment on attachment 134757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134757&action=review > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:168 > -#if ENABLE(INPUT_COLOR) > +#if ENABLE_INPUT_TYPE_COLOR Isn't it ENABLE(INPUT_TYPE_COLOR) ?
Keishi Hattori
Comment 6 2012-03-30 04:30:44 PDT
Created attachment 134773 [details] Patch
Kent Tamura
Comment 7 2012-03-30 06:00:25 PDT
Comment on attachment 134773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134773&action=review > Source/WebKit/chromium/features.gypi:56 > - 'ENABLE_INPUT_TYPE_COLOR=0', > + 'ENABLE_INPUT_TYPE_COLOR=1', Maybe we need something for aura and Android?
WebKit Review Bot
Comment 8 2012-03-30 06:15:46 PDT
Comment on attachment 134773 [details] Patch Clearing flags on attachment: 134773 Committed r112658: <http://trac.webkit.org/changeset/112658>
WebKit Review Bot
Comment 9 2012-03-30 06:15:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.