Bug 80971

Summary: Remove obsolete constructors of CSSPrimitiveValue class.
Product: WebKit Reporter: Kwonjin Jeong <gram>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, kling, koivisto, macpherson, menard, ossy, webkit.review.bot, yuqiang.xian
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 81077    
Attachments:
Description Flags
Patch
none
Patch none

Description Kwonjin Jeong 2012-03-13 00:32:30 PDT 
In CSSPrimitiveValueMappings.h file, there are many specialized template functions for CSSPrimitiveValue class. but the following constructors can't be reached.
* template<> inline CSSPrimitiveValue::CSSPrimitiveValue(int i)
* template<> inline CSSPrimitiveValue::CSSPrimitiveValue(unsigned i)

For the each constructors, there exists overloaded constructor that has the same parameter types as corresponding constructor. Therefore, the overloaded constructor is always called instead of template specialized one.

Moreover, they cause compile errors on the Intel compiler(icpc version 12.1.0) because icpc doesn't allow template function specialization with same parameter types as overloaded function.
Comment 1 Kwonjin Jeong 2012-03-13 00:39:16 PDT 
Created attachment 131566 [details]
Patch
Comment 2 Kwonjin Jeong 2012-03-13 00:47:31 PDT 
Created attachment 131567 [details]
Patch
Comment 3 Kwonjin Jeong 2012-03-13 22:06:45 PDT 
I create a new bug for Intel compiler support on Linux QT port.
https://bugs.webkit.org/show_bug.cgi?id=81077

You can build using Intel compiler referring to the bug.
Comment 4 Kwonjin Jeong 2012-03-14 18:06:45 PDT 
Would you give me some review about this patch?
Comment 5 WebKit Review Bot 2012-03-14 19:09:41 PDT 
Comment on attachment 131567 [details]
Patch

Clearing flags on attachment: 131567

Committed r110807: <http://trac.webkit.org/changeset/110807>
Comment 6 WebKit Review Bot 2012-03-14 19:09:46 PDT 
All reviewed patches have been landed.  Closing bug.