Summary: | flexbox's computePreferredLogicalWidth needs to take multiline into account | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hyatt, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 62048 | ||||||||
Attachments: |
|
Description
Tony Chang
2012-03-12 19:53:53 PDT
Created attachment 131498 [details]
Patch
Comment on attachment 131498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131498&action=review cq- just to give you a chance to address the nits if you want to. > Source/WebCore/rendering/RenderFlexibleBox.cpp:192 > + if (!isMultiline()) Nit: here and below i'd prefer to invert the if statement. > Source/WebCore/rendering/RenderFlexibleBox.cpp:861 > + if (!isColumnFlow() && crossAxisLength().isAuto()) s/crossAxisLength/logicalHeight ? Not sure if that's better or worse. Created attachment 131641 [details]
Patch for landing
Comment on attachment 131641 [details] Patch for landing Clearing flags on attachment: 131641 Committed r110583: <http://trac.webkit.org/changeset/110583> All reviewed patches have been landed. Closing bug. |