Bug 80927

Summary: [V8][Refactoring] Remove existingWrapper() from generated code
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-03-12 19:20:48 PDT
This is the final step for bug 80841. Currently wrap() calls existingWrapper(), and existingWrapper() just calls getCachedWrapper(). We can remove existingWrapper() from the generated code.
Attachments
Patch (19.68 KB, patch)
2012-03-12 19:24 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-03-12 19:24:06 PDT
Created attachment 131493 [details] Patch
Kentaro Hara
Comment 2 2012-03-12 19:25:37 PDT
Comment on attachment 131493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131493&action=review > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:989 > + my $domMapFunction = GetDomMapFunction($dataNode, $interfaceName); Note: At this point, it is guaranteed that IsNodeSubType($dataNode) is false.
WebKit Review Bot
Comment 3 2012-03-12 21:03:44 PDT
Comment on attachment 131493 [details] Patch Clearing flags on attachment: 131493 Committed r110535: <http://trac.webkit.org/changeset/110535>
WebKit Review Bot
Comment 4 2012-03-12 21:03:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.