Summary: | Convert nodesFromRect tests to use Internals interface | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||||||
Component: | Tools / Tests | Assignee: | Antonio Gomes <tonikitoo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gustavo, gyuyoung.kim, jberlin, rakuco, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 80847 | ||||||||||
Attachments: |
|
Description
Antonio Gomes
2012-03-12 14:13:17 PDT
Patch coming.. Created attachment 131450 [details]
patch v1
Comment on attachment 131450 [details] patch v1 Attachment 131450 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11945250 Comment on attachment 131450 [details] patch v1 Attachment 131450 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11947353 (In reply to comment #4) > (From update of attachment 131450 [details]) > Attachment 131450 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/11947353 That is the window link failure: 10>Linking... 10> Creating library C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\lib\DumpRenderTree.exp 10>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: class WTF::PassRefPtr<class WebCore::NodeList> __thiscall WebCore::Document::nodesFromRect(int,int,unsigned int,unsigned int,unsigned int,unsigned int,bool)const " (?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIII_N@Z) referenced in function "public: class WTF::PassRefPtr<class WebCore::NodeList> __thiscall WebCore::Internals::nodesFromRect(class WebCore::Document *,int,int,unsigned int,unsigned int,unsigned int,unsigned int,bool,int &)const " (?nodesFromRect@Internals@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@PAVDocument@2@HHIIII_NAAH@Z) 10>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::NodeList *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNodeList@1@@Z) referenced in function "__int64 __fastcall WebCore::jsInternalsPrototypeFunctionNodesFromRect(class JSC::ExecState *)" (?jsInternalsPrototypeFunctionNodesFromRect@WebCore@@YI_JPAVExecState@JSC@@@Z) 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\bin\DumpRenderTree.dll : fatal error LNK1120: 2 unresolved externals 10>Build log was saved at "file://C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\obj\DumpRenderTree\BuildLog.htm" 10>DumpRenderTree - 3 error(s), 0 warning(s) @Jessie, would you know how can I fix it? (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 131450 [details] [details]) > > Attachment 131450 [details] [details] did not pass win-ews (win): > > Output: http://queues.webkit.org/results/11947353 > > That is the window link failure: > > 10>Linking... > 10> Creating library C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\lib\DumpRenderTree.exp > 10>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: class WTF::PassRefPtr<class WebCore::NodeList> __thiscall WebCore::Document::nodesFromRect(int,int,unsigned int,unsigned int,unsigned int,unsigned int,bool)const " (?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIII_N@Z) referenced in function "public: class WTF::PassRefPtr<class WebCore::NodeList> __thiscall WebCore::Internals::nodesFromRect(class WebCore::Document *,int,int,unsigned int,unsigned int,unsigned int,unsigned int,bool,int &)const " (?nodesFromRect@Internals@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@PAVDocument@2@HHIIII_NAAH@Z) > 10>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::NodeList *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNodeList@1@@Z) referenced in function "__int64 __fastcall WebCore::jsInternalsPrototypeFunctionNodesFromRect(class JSC::ExecState *)" (?jsInternalsPrototypeFunctionNodesFromRect@WebCore@@YI_JPAVExecState@JSC@@@Z) > 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\bin\DumpRenderTree.dll : fatal error LNK1120: 2 unresolved externals > 10>Build log was saved at "file://C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\obj\DumpRenderTree\BuildLog.htm" > 10>DumpRenderTree - 3 error(s), 0 warning(s) > > > @Jessie, would you know how can I fix it? I think you need to export these symbols in WebKit2.def (for an example, see http://trac.webkit.org/changeset/99613/trunk/Source/WebKit2/win/WebKit2.def). Created attachment 131637 [details]
patch v2 - buildfixes for gtk and win (attempt)
Comment on attachment 131637 [details] patch v2 - buildfixes for gtk and win (attempt) Attachment 131637 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11949503 Created attachment 131657 [details] (committed r110594 r=rniwa) patch v3 - win buildfixes - more symbols exported Comment on attachment 131657 [details] (committed r110594 r=rniwa) patch v3 - win buildfixes - more symbols exported View in context: https://bugs.webkit.org/attachment.cgi?id=131657&action=review > Source/WebCore/testing/Internals.cpp:686 > + unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding, Nit: wrong indentation. We don't align arguments like this. > Source/WebCore/testing/Internals.h:127 > + PassRefPtr<NodeList> nodesFromRect(Document*, int /*x*/, int /*y*/, We don't put variable names in comments > Source/WebCore/testing/Internals.h:128 > + unsigned /*topPadding*/, unsigned /*rightPadding*/, unsigned /*bottomPadding*/, unsigned /*leftPadding*/, Ditto about the indentation > Source/WebCore/testing/Internals.idl:102 > + NodeList nodesFromRect(in Document document, in long x, in long y, Ditto about the indentation |