Summary: | flex-item-align: stretch should only grow, never shrink | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | Layout and Rendering | Assignee: | Tony Chang <tony> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 62048 | ||||||||
Attachments: |
|
Description
Tony Chang
2012-03-12 13:51:49 PDT
Created attachment 132390 [details]
Patch
Comment on attachment 132390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132390&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:1014 > +void RenderFlexibleBox::alignChildStretch(RenderBox* child, LayoutUnit lineCrossAxisExtent) Nit: I find this method name awkward. It reads to me as if it's aligning the stretch itself (which is nonsensical). applyChildStretch perhaps? Created attachment 132403 [details]
Patch for landing
(In reply to comment #2) > (From update of attachment 132390 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132390&action=review > > > Source/WebCore/rendering/RenderFlexibleBox.cpp:1014 > > +void RenderFlexibleBox::alignChildStretch(RenderBox* child, LayoutUnit lineCrossAxisExtent) > > Nit: I find this method name awkward. It reads to me as if it's aligning the stretch itself (which is nonsensical). applyChildStretch perhaps? Now named applyStretchAlignmentToChild. Comment on attachment 132403 [details] Patch for landing Clearing flags on attachment: 132403 Committed r111094: <http://trac.webkit.org/changeset/111094> All reviewed patches have been landed. Closing bug. Reverted r111094 for reason: broke Committed r111103: <http://trac.webkit.org/changeset/111103> Committed r111214: <http://trac.webkit.org/changeset/111214> css3/flexbox/child-overflow.html was failing due to https://bugs.webkit.org/show_bug.cgi?id=77368, so I just landed with it marked as failing in test_expectations.txt. |