Bug 80875

Summary: GestureTapDown needs to pin in-progress flings
Product: WebKit Reporter: Robert Kroeger <rjkroege>
Component: UI EventsAssignee: Robert Kroeger <rjkroege>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, rjkroege, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Robert Kroeger
Reported 2012-03-12 13:10:35 PDT
GestureTapDown should pin (i.e. stop) any in-progress animation.
Attachments
Patch (2.79 KB, patch)
2012-03-12 13:18 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Patch (2.79 KB, patch)
2012-03-16 15:50 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Kroeger
Comment 1 2012-03-12 13:18:58 PDT
Created attachment 131392 [details] Patch
Robert Kroeger
Comment 2 2012-03-12 15:04:55 PDT
abarth@: please take a look?
Adam Barth
Comment 3 2012-03-15 15:41:58 PDT
Comment on attachment 131392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131392&action=review This looks fine. I'm always torn for these patch in how hard I should push you for tests. It seems like we don't have much test coverage for this code, which makes me worry that we'll break it in the future. > Source/WebCore/page/EventHandler.cpp:2371 > + FrameView* view = m_frame->view(); > + if (view) { Prefer early return. > Source/WebCore/page/EventHandler.cpp:2375 > + return false; Bad indent.
Robert Kroeger
Comment 4 2012-03-15 16:17:41 PDT
About tests: there should be a better way to test ScrollAnimatorNone-based behaviour. I plan on trying to write something as a prereq for https://bugs.webkit.org/show_bug.cgi?id=80596.
Robert Kroeger
Comment 5 2012-03-16 15:50:42 PDT
Created attachment 132408 [details] Patch
WebKit Review Bot
Comment 6 2012-03-16 17:52:33 PDT
Comment on attachment 132408 [details] Patch Clearing flags on attachment: 132408 Committed r111101: <http://trac.webkit.org/changeset/111101>
WebKit Review Bot
Comment 7 2012-03-16 17:52:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.