Bug 80873

Summary: Removing HTMLTrackElement does not delete TextTrack
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: Media ElementsAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: vcarbune, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 43668    
Attachments:
Description Flags
Proposed patch koivisto: review+

Description Eric Carlson 2012-03-12 13:02:31 PDT
r105434 introduced a bug which causes a HTMLTrackElement's TextTrack to not be removed from the HTMLMediaElement's tracks collection.
Comment 1 Radar WebKit Bug Importer 2012-03-12 13:03:49 PDT
<rdar://problem/11031795>
Comment 2 Eric Carlson 2012-03-12 14:19:52 PDT
Created attachment 131408 [details]
Proposed patch
Comment 3 Victor Carbune 2012-03-14 12:23:39 PDT
I believe I can't review+ it, but nice catch and the patch looks good to me.
Comment 4 Antti Koivisto 2012-03-20 07:21:03 PDT
Comment on attachment 131408 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131408&action=review

r=me

> Source/WebCore/html/HTMLMediaElement.h:208
>      virtual void trackWasAdded(HTMLTrackElement*);
> -    virtual void trackWasRemoved(HTMLTrackElement*);
> +    virtual void trackWillBeRemoved(HTMLTrackElement*);

I think the usual naming pattern is didAddTrack/willRemoveTrack
Comment 5 Eric Carlson 2012-03-21 11:29:35 PDT
http://trac.webkit.org/changeset/111581