Bug 80873

Summary: Removing HTMLTrackElement does not delete TextTrack
Product: WebKit Reporter: Eric Carlson <eric.carlson@apple.com>
Component: Media ElementsAssignee: Eric Carlson <eric.carlson@apple.com>
Status: RESOLVED FIXED    
Severity: Normal CC: vcarbune@chromium.org, webkit-bug-importer@group.apple.com
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 43668    
Attachments:
Description Flags
Proposed patch koivisto: review+

Description From 2012-03-12 13:02:31 PST
r105434 introduced a bug which causes a HTMLTrackElement's TextTrack to not be removed from the HTMLMediaElement's tracks collection.
------- Comment #1 From 2012-03-12 13:03:49 PST -------
<rdar://problem/11031795>
------- Comment #2 From 2012-03-12 14:19:52 PST -------
Created an attachment (id=131408) [details]
Proposed patch
------- Comment #3 From 2012-03-14 12:23:39 PST -------
I believe I can't review+ it, but nice catch and the patch looks good to me.
------- Comment #4 From 2012-03-20 07:21:03 PST -------
(From update of attachment 131408 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=131408&action=review

r=me

> Source/WebCore/html/HTMLMediaElement.h:208
>      virtual void trackWasAdded(HTMLTrackElement*);
> -    virtual void trackWasRemoved(HTMLTrackElement*);
> +    virtual void trackWillBeRemoved(HTMLTrackElement*);

I think the usual naming pattern is didAddTrack/willRemoveTrack
------- Comment #5 From 2012-03-21 11:29:35 PST -------
http://trac.webkit.org/changeset/111581