Bug 80868

Summary: Make texImage2D error for wrong size ArrayBufferView more helpful
Product: WebKit Reporter: Gregg Tavares <gman>
Component: WebGLAssignee: Gregg Tavares <gman>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Gregg Tavares
Reported 2012-03-12 12:35:47 PDT
Make texImage2D error for wrong size ArrayBufferView more helpful
Attachments
Patch (2.10 KB, patch)
2012-03-12 12:38 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gregg Tavares
Comment 1 2012-03-12 12:38:03 PDT
Created attachment 131383 [details] Patch
Gregg Tavares
Comment 2 2012-03-12 12:40:12 PDT
I could just change the original message instead of adding the special check. I could also change the new message to something more verbose like "ArrayBufferView not big enough for request but would be if UNPACK_ALIGNMENT was set to 1" thoughts?
Kenneth Russell
Comment 3 2012-03-12 13:01:44 PDT
Comment on attachment 131383 [details] Patch Looks good. r=me
WebKit Review Bot
Comment 4 2012-03-12 14:15:38 PDT
Comment on attachment 131383 [details] Patch Clearing flags on attachment: 131383 Committed r110477: <http://trac.webkit.org/changeset/110477>
WebKit Review Bot
Comment 5 2012-03-12 14:15:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.