Bug 80867 (Window_BUILD)

Summary:

Build fails on Windows due to missing "Include directories" paths

Product:

WebKit

Reporter:

Pravin D <pravind.2k4>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED ---

Severity:

Critical

CC:

83.samarth, abarth, ap, arpitabahuguna, bweinstein, eric, jberlin, king_pirate11, mrahaman, pravind.2k4, vivekgalatage

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	abarth: review-

Description Pravin D 2012-03-12 12:15:08 PDT

Webcore module fails to build on windows 7 due to missing WTF header files. Due to the change in WTF and addition of WTFGenerated proj, the webcore is unable to find the WTF header files.

Checked on Windows 7 build Revision 110420.


Additional Information:
Attached the build log for the same.

Comment 1 Pravin D 2012-03-12 12:42:54 PDT

Created attachment 131385 [details]
Patch

Comment 2 Adam Barth 2012-03-12 23:43:15 PDT

Comment on attachment 131385 [details]
Patch

Windows seems to be building fine at top-of-tree:
http://build.webkit.org/waterfall?category=AppleWin

Maybe the problem is related to your local configuration?

Comment 3 Mustafizur Rahaman( :rahaman) 2012-03-12 23:44:05 PDT

(In reply to comment #1)
> Created an attachment (id=131385) [details]
> Patch

Should we fix the issue in this way Or as per https://lists.webkit.org/pipermail/webkit-dev/2012-March/019770.html, we should replace all instance of "Headerfile.h" with #include <wtf/Headerfile.h> ?

Comment 4 Pravin D 2012-03-12 23:50:22 PDT

(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=131385) [details] [details]
> > Patch
> 
> Should we fix the issue in this way Or as per https://lists.webkit.org/pipermail/webkit-dev/2012-March/019770.html, we should replace all instance of "Headerfile.h" with #include <wtf/Headerfile.h> ?

Fixing all the instance of "Headerfile.h" with #include <wtf/Headerfile.h> will be much more involved and prone to errors as than just adding extra include directories.

Comment 5 Pravin D 2012-03-12 23:55:05 PDT

(In reply to comment #2)
> (From update of attachment 131385 [details])
> Windows seems to be building fine at top-of-tree:
> http://build.webkit.org/waterfall?category=AppleWin
> 
> Maybe the problem is related to your local configuration?

I'm not sure if it is a local configuration issue. Is there way to check it ?

Comment 6 Adam Barth 2012-03-12 23:55:24 PDT

#include <wtf/Headerfile.h> is the correct way.

Comment 7 Mustafizur Rahaman( :rahaman) 2012-03-13 00:03:19 PDT

(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 131385 [details] [details])
> > Windows seems to be building fine at top-of-tree:
> > http://build.webkit.org/waterfall?category=AppleWin
> > 
> > Maybe the problem is related to your local configuration?
> 
> I'm not sure if it is a local configuration issue. Is there way to check it ?

The revision you are using has the issue, as I also got same issue. But the latest revision seems to have solved it as Adam was suggesting.

Comment 8 Pravin D 2012-03-13 00:37:48 PDT

(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #2)
> > > (From update of attachment 131385 [details] [details] [details])
> > > Windows seems to be building fine at top-of-tree:
> > > http://build.webkit.org/waterfall?category=AppleWin
> > > 
> > > Maybe the problem is related to your local configuration?
> > 
> > I'm not sure if it is a local configuration issue. Is there way to check it ?
> 
> The revision you are using has the issue, as I also got same issue. But the latest revision seems to have solved it as Adam was suggesting.

Ok thanks

Comment 9 Jessie Berlin 2012-03-13 08:59:42 PDT

As adam barth said, the correct way to fix this is to to <wtf/HeaderFile.h>.

Are you still seeing build issues? If not, please close this bug.