Bug 80862

Summary: [Chromium] Temporary build-fix for the Android bot
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80861    
Attachments:
Description Flags
Patch none

Peter Beverloo
Reported 2012-03-12 11:33:51 PDT
[Chromium] Temporary build-fix for the Android bot
Attachments
Patch (1.98 KB, patch)
2012-03-12 11:35 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-03-12 11:35:07 PDT
Created attachment 131364 [details] Patch
Peter Beverloo
Comment 2 2012-03-12 11:40:34 PDT
Firstly: Yes, I'm aware that this is horrible. A change in the Android envsetup.sh script at Chromium[1] has broken the WebKit Android builder, among another configuration. A Chromium-side fix is being created by bulach@ downstream but isn't ready to be upstreamed yet, and getting that into WebKit would take another day. In the meantime there are two other compile errors which have gone unnoticed, unfortunately both on the Chromium side as well. To make sure things don't get significantly worse I'd like to have the bot compiling *something* asap, aiming to be completely green again by the end of this week. This code will be removed very shortly after the Chromium-side fix is available, which shouldn't be more than a few days. [1] http://src.chromium.org/viewvc/chrome?view=rev&revision=124565
Adam Barth
Comment 3 2012-03-12 11:41:59 PDT
Comment on attachment 131364 [details] Patch Ok.
Peter Beverloo
Comment 4 2012-03-12 11:43:12 PDT
Comment on attachment 131364 [details] Patch Thanks!
WebKit Review Bot
Comment 5 2012-03-12 12:50:51 PDT
Comment on attachment 131364 [details] Patch Clearing flags on attachment: 131364 Committed r110460: <http://trac.webkit.org/changeset/110460>
WebKit Review Bot
Comment 6 2012-03-12 12:50:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.