Bug 80858

Summary: Connect up fling event delivery to gesture curve animation framework
Product: WebKit Reporter: Robert Kroeger <rjkroege>
Component: UI EventsAssignee: Robert Kroeger <rjkroege>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, webkit.review.bot, wjmaclean, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80607    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Robert Kroeger
Reported 2012-03-12 10:47:43 PDT
To let https://bugs.webkit.org/show_bug.cgi?id=79827 and https://bugs.webkit.org/show_bug.cgi?id=80311 land separately, it was necessary to remove the final wiring connecting them. Add the necessary plumbing.
Attachments
Patch (1.48 KB, patch)
2012-03-12 11:05 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2012-03-15 18:07 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Kroeger
Comment 1 2012-03-12 11:05:18 PDT
Created attachment 131353 [details] Patch
Gustavo Noronha (kov)
Comment 2 2012-03-12 11:15:29 PDT
Comment on attachment 131353 [details] Patch Attachment 131353 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11938985
WebKit Review Bot
Comment 3 2012-03-12 11:25:34 PDT
Comment on attachment 131353 [details] Patch Attachment 131353 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11939950
Robert Kroeger
Comment 4 2012-03-12 12:17:04 PDT
note: needs 80607 to build.
Adam Barth
Comment 5 2012-03-12 15:10:32 PDT
Comment on attachment 131353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131353&action=review > Source/WebCore/platform/ScrollAnimatorNone.cpp:397 > + if (!!m_gestureAnimation) Do you need the !! here?
Robert Kroeger
Comment 6 2012-03-13 08:38:49 PDT
Comment on attachment 131353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131353&action=review >> Source/WebCore/platform/ScrollAnimatorNone.cpp:397 >> + if (!!m_gestureAnimation) > > Do you need the !! here? probably not. I'll update if so prior to committing.
Robert Kroeger
Comment 7 2012-03-15 18:07:44 PDT
Created attachment 132167 [details] Patch
WebKit Review Bot
Comment 8 2012-03-16 03:20:18 PDT
Comment on attachment 132167 [details] Patch Clearing flags on attachment: 132167 Committed r110978: <http://trac.webkit.org/changeset/110978>
WebKit Review Bot
Comment 9 2012-03-16 03:20:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.