Bug 8085

Summary: REGRESSION: Main menu positioned incorrectly on eia.org and fedex.com/us
Product: WebKit Reporter: mitz
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: VERIFIED FIXED    
Severity: Normal CC: bdakin, daniele.metilli
Priority: P1 Keywords: NeedsReduction, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.eia.org/
Attachments:
Description Flags
Fix table cells' offsetTop bdakin: review+

mitz
Reported 2006-03-30 09:48:47 PST
The green menu bar on eia.org should be at the top, right below the blue site head. In TOT it appears in the middle of the page.
Attachments
Fix table cells' offsetTop (4.09 KB, patch)
2006-04-03 13:01 PDT, mitz 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-04-01 10:40:18 PST
This bug seems to be caused at least in part by offsetTop() returning the wrong offset, for the same underlying reason as bug 8081. I tried skipping table rows in RenderObject::offsetTop() but it didn't fix the bug completely, only moved the menu up.
mitz
Comment 2 2006-04-02 09:00:49 PDT
This bug is seen also in http://fedex.com/us/ . I also noticed that the EIA site behaves differently when I set the user agent to Netscape 7 (still off, but not by as much), so maybe they have Safari-specific code to work around the old behavior where table rows' offsetTop was 0, and the fix for this bug is really not to add table rows in RenderObject::offsetTop().
mitz
Comment 3 2006-04-03 08:44:52 PDT
*** Bug 8151 has been marked as a duplicate of this bug. ***
mitz
Comment 4 2006-04-03 13:01:53 PDT
Created attachment 7489 [details] Fix table cells' offsetTop This patch fixes fedex.com and the site mentioned in bug 8151 but not eia.org. I think the latter either has Safari-specific code to accommodate the old behavior (of rows' offsetTop being 0) or there's a different bug affecting it. fast/dom seems like the wrong place for the layout test. Feel free to relocate it when-if landing.
Note You need to log in before you can comment on or make changes to this bug.