Bug 80812

Summary:

[BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port

Product:

WebKit

Reporter:

Ming Xie <mxie>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Unspecified

Attachments:

Description	Flags
Patch for the fix	none

Ming Xie

Reported 2012-03-11 22:28:18 PDT

For the BlackBerry port, "--cmakearg" from build-webkit options doesn't get passed to buildCMakeProjectOrExit() Also, "PUBLIC_BUILD=0" should not be hard-coded in blackberryCMakeArguments()

Attachments
Patch for the fix (2.39 KB, patch) 2012-03-11 22:44 PDT, Ming Xie	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ming Xie

Comment 1 2012-03-11 22:44:03 PDT

Created attachment 131282 [details] Patch for the fix

Rob Buis

Comment 2 2012-03-12 06:37:25 PDT

Comment on attachment 131282 [details] Patch for the fix LGTM.

WebKit Review Bot

Comment 3 2012-03-12 07:52:33 PDT

Comment on attachment 131282 [details] Patch for the fix Clearing flags on attachment: 131282 Committed r110427: <http://trac.webkit.org/changeset/110427>

WebKit Review Bot

Comment 4 2012-03-12 07:52:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.