Bug 80809

Summary: [GTK] r110296 included an extra $ in @$(AM_V_GEN)
Product: WebKit Reporter: C Anthony <anthony>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: ibiru, mrobinson, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
simple fix
none
Patch none

C Anthony
Reported 2012-03-11 21:59:40 PDT
see: http://trac.webkit.org/changeset/110296/trunk/Tools/GNUmakefile.am that should have been (note the additional `$` !!!): @$(AM_V_GEN)$(PYTHON) ... NOT ... @(AM_V_GEN)$(PYTHON) ... which causes a syntax error in /bin/sh (the @ tells make to run the following command silently).
Attachments
simple fix (447 bytes, patch)
2012-03-11 22:03 PDT, C Anthony 		no flags
DetailsFormatted DiffDiff
Patch (1.17 KB, patch)
2012-03-12 09:53 PDT, C Anthony 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
C Anthony
Comment 1 2012-03-11 22:03:38 PDT
Created attachment 131280 [details] simple fix self-explanatory :-)
WebKit Review Bot
Comment 2 2012-03-11 22:05:02 PDT
Attachment 131280 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 3 2012-03-12 09:24:24 PDT
Can you please provide a ChangeLog entry?
C Anthony
Comment 4 2012-03-12 09:53:09 PDT
Created attachment 131341 [details] Patch
C Anthony
Comment 5 2012-03-12 09:54:51 PDT
ok, i used `Tools/Scripts/webkit-patch upload` this time :-)
Philippe Normand
Comment 6 2012-03-12 10:09:56 PDT
*** Bug 80695 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 7 2012-03-12 10:51:04 PDT
Comment on attachment 131341 [details] Patch Clearing flags on attachment: 131341 Committed r110446: <http://trac.webkit.org/changeset/110446>
WebKit Review Bot
Comment 8 2012-03-12 10:51:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.