Bug 80798

Summary: Web Inspector: WebKit1: update how the Web Inspector resources are loaded
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, timothy, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Change none

Timothy Hatcher
Reported 2012-03-11 17:47:35 PDT
We need to update how WebKit1 loads the Web Inspector resources. <rdar://problem/10359959>
Attachments
Proposed Change (9.20 KB, patch)
2012-03-11 17:53 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2012-03-11 17:53:20 PDT
Created attachment 131263 [details] Proposed Change
Brian Weinstein
Comment 2 2012-03-11 17:58:28 PDT
Comment on attachment 131263 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=131263&action=review > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:166 > + ![[NSBundle bundleWithIdentifier:@"com.apple.WebInspector"] pathForResource:@"Main" ofType:@"html"]; Should we save this result into a static so we don't have to compute this each time?
Timothy Hatcher
Comment 3 2012-03-11 18:01:29 PDT
Nah, it isn't hot code.
WebKit Review Bot
Comment 4 2012-03-11 18:14:24 PDT
Comment on attachment 131263 [details] Proposed Change Clearing flags on attachment: 131263 Committed r110403: <http://trac.webkit.org/changeset/110403>
WebKit Review Bot
Comment 5 2012-03-11 18:14:28 PDT
All reviewed patches have been landed. Closing bug.
Timothy Hatcher
Comment 6 2012-03-11 18:29:45 PDT
Build fix landed in r110404.
Note You need to log in before you can comment on or make changes to this bug.