Summary: | Web Inspector: WebKit1: update how the Web Inspector resources are loaded | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bweinstein, joepeck, timothy, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Timothy Hatcher
2012-03-11 17:47:35 PDT
Created attachment 131263 [details]
Proposed Change
Comment on attachment 131263 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=131263&action=review > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:166 > + ![[NSBundle bundleWithIdentifier:@"com.apple.WebInspector"] pathForResource:@"Main" ofType:@"html"]; Should we save this result into a static so we don't have to compute this each time? Nah, it isn't hot code. Comment on attachment 131263 [details] Proposed Change Clearing flags on attachment: 131263 Committed r110403: <http://trac.webkit.org/changeset/110403> All reviewed patches have been landed. Closing bug. |