Bug 80701

Summary:

getCueAsHTML() should return different fragments

Product:

WebKit

Reporter:

Victor Carbune <vcarbune>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

79746

Attachments:

Description	Flags
Fixed method and added test	none

Description Victor Carbune 2012-03-09 06:40:09 PST

Currently, the document fragment returned by getCueAsHTML() can't be appended multiple times to the DOM.

Comment 1 Victor Carbune 2012-03-09 06:57:41 PST

Created attachment 131036 [details]
Fixed method and added test

Comment 2 Eric Carlson 2012-03-09 10:25:21 PST

Comment on attachment 131036 [details]
Fixed method and added test

View in context: https://bugs.webkit.org/attachment.cgi?id=131036&action=review

Nice fix and terrific test - thanks!

> Source/WebCore/html/track/TextTrackCue.cpp:362
> +    RefPtr<DocumentFragment> clonedFragment;
> +    Document* document;

Nit: There is no need to declare these here and initialize them further down in the function. No need to have this block landing the fix, but lets fix it the next time we modify this file.

Comment 3 WebKit Review Bot 2012-03-09 11:16:28 PST

Comment on attachment 131036 [details]
Fixed method and added test

Clearing flags on attachment: 131036

Committed r110308: <http://trac.webkit.org/changeset/110308>

Comment 4 WebKit Review Bot 2012-03-09 11:16:32 PST

All reviewed patches have been landed.  Closing bug.