Summary: | [BlackBerry] Web Notification not working after rebase | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Charles Wei <charles.wei> | ||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Charles Wei
2012-03-09 02:40:57 PST
Internal PR: 142886 Created attachment 131022 [details]
Patch
With this patch, we did:
1. Namespace of NotificationPresenterImpl moved from WebKit to WebCore. All code in WebCoreSupport should be in the namespace of WebCore.
2. Remove the un-needed ChromeClientBlackBerry::notificationPresenter
3. Connect the NotificationPresenter to WebCore using WebCore::provideNotification(Page*, NotificationPresenter*).
Comment on attachment 131022 [details] Patch Clearing flags on attachment: 131022 Committed r110290: <http://trac.webkit.org/changeset/110290> All reviewed patches have been landed. Closing bug. This should not have landed. We are not landing any m35 only patches until it is deployed. .. What should we do reopening it? should we revert the patch ? Well, we can close it. I do not think it can cause backport problems. Rob also landed a few patches in the same situation (m35) , but we've agreed to wait a bit, and some patches are on hold. Lets leave this one in : ) why not? |