Bug 80689

Summary: [Qt] fast/viewport/viewport-133.html fails
Product: WebKit Reporter: Nandor Huszka <hnandor>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kpiascik, ossy, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Nandor Huszka
Reported 2012-03-09 02:28:12 PST
Because of r110197 this test fails.
Attachments
patch (1.32 KB, patch)
2012-06-06 11:09 PDT, qi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-03-09 02:36:39 PST
I don't think if we need one more bug report for it. *** This bug has been marked as a duplicate of bug 80292 ***
Konrad Piascik
Comment 2 2012-03-09 11:59:15 PST
I don't believe that this is a duplicate of bug 80292 but is a bug in its own right. I don't have privileges to edit bugs otherwise I'd re-open it. The other ports EFL and GTK don't make the following call: d->page->setDeviceScaleFactor(conf.devicePixelRatio); http://trac.webkit.org/browser/trunk/Source/WebKit/qt/Api/qwebpage.cpp?rev=93303#L2571 The above call should be updating window.devicePixelRatio. Since this isn't happening I think that there may be an issue with Qt. which fast/viewport/viewport-133.html uncovered.
Csaba Osztrogonác
Comment 3 2012-03-10 01:18:18 PST
.
qi
Comment 4 2012-06-06 11:09:32 PDT
Created attachment 146065 [details] patch This test case was removed (https://bugs.webkit.org/show_bug.cgi?id=88047). It is not valid case now. Remove it form skip list.
WebKit Review Bot
Comment 5 2012-06-08 07:11:49 PDT
Comment on attachment 146065 [details] patch Clearing flags on attachment: 146065 Committed r119827: <http://trac.webkit.org/changeset/119827>
WebKit Review Bot
Comment 6 2012-06-08 07:11:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.