Bug 80686

Summary: HTML parser: allow <hr> to be used inside <select> as a separator
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Anne van Kesteren <annevk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adele, annevk, ap, dglazkov, eric, hyatt, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://github.com/whatwg/html/issues/3410
https://github.com/whatwg/html/pull/9124
Bug Depends on:    
Bug Blocks: 41115    
Attachments:
Description Flags
Reproducible HTML none

Kent Tamura
Reported 2012-03-09 01:57:28 PST
Created attachment 131013 [details] Reproducible HTML We have a feature that <hr> children in a <select> represent a menu separator. http://www.webkit.org/blog/32/webkit-fixes-in-safari-202-mac-os-x-1043/ > Menu separator support: an <hr> inside a <select> with size 1 will now add a horizontal separator in the menu. This feature doesn't work for now if such markup is parsed by the parser. It works if we insert <hr> into a <select> by a DOM operation. Open the attached HTML, and see the difference between two popup menus.
Attachments
Reproducible HTML (506 bytes, text/html)
2012-03-09 01:57 PST, Kent Tamura 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2012-03-09 08:44:10 PST
I think we need to change the spec first. It says that hr should be ignored: http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#parsing-main-inselect
Adam Barth
Comment 2 2012-03-09 08:48:44 PST
Or we should drop the feature if it's not implemented by other rendering engines.
Kent Tamura
Comment 3 2012-03-11 19:14:54 PDT
It seems Chromium is using this feature for a popup menu in chrome://settings/fonts.
Adam Barth
Comment 4 2012-03-11 20:23:56 PDT
> It seems Chromium is using this feature for a popup menu in chrome://settings/fonts. Chromium shouldn't constrain us. We can change Chromium to use a more wildly supported API.
Adele Peterson
Comment 5 2012-03-11 23:04:32 PDT
I originally added this support for an Apple Dashboard widget that is no longer using that markup. Unfortunately, I think there were other clients over the years. I'll have to check to see if we have any reports about this not working in the latest Safari/OS X WebKit, but I suspect no one has noticed.
Radar WebKit Bug Importer
Comment 6 2023-04-05 06:41:26 PDT
<rdar://problem/107656886>
Anne van Kesteren
Comment 7 2023-04-05 06:44:37 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12407
EWS
Comment 8 2023-05-03 01:15:24 PDT
Committed 263624@main (d9e3a6262dbe): <https://commits.webkit.org/263624@main> Reviewed commits have been landed. Closing PR #12407 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.