| Summary: | Missing some places where we should be blinding 64bit values (and blinding something we shouldn't) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
| Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Oliver Hunt
2012-03-08 13:27:08 PST
Created attachment 130890 [details]
Patch
Attachment 130890 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/MacroAssembler.h:524: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r110200: <http://trac.webkit.org/changeset/110200> This broke quite a few things I believe. http://build.webkit.org/builders/Qt%20Linux%20Release/builds/44191/steps/compile-webkit/logs/stdio http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/44369/steps/compile-webkit/logs/stdio http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/41111/steps/compile-webkit/logs/stdio |