Bug 80633 - Missing some places where we should be blinding 64bit values (and blinding something we shouldn't)
Summary: Missing some places where we should be blinding 64bit values (and blinding so...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-08 13:27 PST by Oliver Hunt
Modified: 2012-03-08 14:29 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.71 KB, patch)
2012-03-08 13:31 PST, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-03-08 13:27:08 PST
Missing some places where we should be blinding 64bit values (and blinding something we shouldn't)
Comment 1 Oliver Hunt 2012-03-08 13:31:12 PST
Created attachment 130890 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-08 13:33:35 PST
Attachment 130890 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/MacroAssembler.h:524:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2012-03-08 13:59:13 PST
Committed r110200: <http://trac.webkit.org/changeset/110200>
Comment 5 Oliver Hunt 2012-03-08 14:29:31 PST
Committed r110206