Summary: | [Qt][WK2] Move code common to both ProxyAuthentication and Authentication context objects into a base class | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dinu Jacob <dinu.jacob> | ||||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ahf, hausmann, menard, webkit.review.bot, zoltan | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Dinu Jacob
2012-03-08 12:25:00 PST
Created attachment 130877 [details]
Patch
Created attachment 130891 [details]
Patch
Comment on attachment 130891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130891&action=review Informal r=me, but I am not a reviewer :-) > Source/WebKit2/ChangeLog:8 > + Maybe add a note to the ChangeLog like "This change does not affect the QML API". > Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:101 > +class AuthenticationDialogContextObject : public BaseAuthenticationContextObject { Maybe change this HttpAuthenticationDialogContextObject? Comment on attachment 130891 [details]
Patch
Making it official
(In reply to comment #3) > (From update of attachment 130891 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130891&action=review > > Informal r=me, but I am not a reviewer :-) > > > Source/WebKit2/ChangeLog:8 > > + > > Maybe add a note to the ChangeLog like "This change does not affect the QML API". > > > Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:101 > > +class AuthenticationDialogContextObject : public BaseAuthenticationContextObject { > > Maybe change this HttpAuthenticationDialogContextObject? Sure, will do that. In general, I think a lot of this code could easily be cleaned up :-) Created attachment 131861 [details]
Patch for landing
Comment on attachment 131861 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=131861&action=review > Source/WebKit2/ChangeLog:8 > + No impact to AML API. Off-by-one keyboard typo. (In reply to comment #8) > (From update of attachment 131861 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131861&action=review > > > Source/WebKit2/ChangeLog:8 > > + No impact to AML API. > > Off-by-one keyboard typo. ouch :( Will fix that! Thanks. Created attachment 131864 [details]
To be committed
Comment on attachment 131864 [details] To be committed Clearing flags on attachment: 131864 Committed r110781: <http://trac.webkit.org/changeset/110781> All reviewed patches have been landed. Closing bug. |