Bug 80621

Summary:

[BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp

Product:

WebKit

Reporter:

Nima Ghanavatian <nima.ghanavatian>

Component:

WebKit BlackBerry

Assignee:

Nima Ghanavatian <nima.ghanavatian>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Nima Ghanavatian 2012-03-08 11:45:47 PST

A warning is being triggered because control can reach the end of a non-void function.  This should never happen since all the enum's are being accounted for.

I am adding an ASSERT_NOT_REACHED() and returning a valid value.

Comment 1 Nima Ghanavatian 2012-03-08 12:09:51 PST

Created attachment 130871 [details]
Patch

Comment 2 Rob Buis 2012-03-08 12:12:14 PST

Comment on attachment 130871 [details]
Patch

LGTM.

Comment 3 WebKit Review Bot 2012-03-08 19:05:45 PST

Comment on attachment 130871 [details]
Patch

Clearing flags on attachment: 130871

Committed r110249: <http://trac.webkit.org/changeset/110249>

Comment 4 WebKit Review Bot 2012-03-08 19:05:49 PST

All reviewed patches have been landed.  Closing bug.