Bug 80612

Summary: Remove InDocumentFlag manipulation methods from Node interface
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Klein
Reported 2012-03-08 10:53:24 PST
Remove InDocumentFlag manipulation methods from Node interface
Attachments
Patch (4.42 KB, patch)
2012-03-08 10:58 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.50 KB, patch)
2012-03-08 11:11 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2012-03-08 10:58:11 PST
Created attachment 130853 [details] Patch
Ryosuke Niwa
Comment 2 2012-03-08 11:06:13 PST
Comment on attachment 130853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130853&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::ContainerNode::removedFromDocument): Remove duplicate call to clearInDocument. Could you clarify where the flag is cleared?
Adam Klein
Comment 3 2012-03-08 11:08:32 PST
Comment on attachment 130853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130853&action=review >> Source/WebCore/ChangeLog:15 >> + (WebCore::ContainerNode::removedFromDocument): Remove duplicate call to clearInDocument. > > Could you clarify where the flag is cleared? The call to Node::removedFromDocument three lines above will clear the flag (updated my local change with this information).
Adam Klein
Comment 4 2012-03-08 11:11:36 PST
Created attachment 130857 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-03-08 14:48:00 PST
Comment on attachment 130857 [details] Patch for landing Clearing flags on attachment: 130857 Committed r110207: <http://trac.webkit.org/changeset/110207>
WebKit Review Bot
Comment 6 2012-03-08 14:48:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.