Bug 80592

Summary: Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ericu, fishd, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch with merged blocks none

Mark Pilgrim (Google)
Reported 2012-03-08 06:18:38 PST
Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
Attachments
Patch (12.72 KB, patch)
2012-03-08 06:21 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch with merged blocks (13.04 KB, patch)
2012-03-08 07:53 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-03-08 06:21:29 PST
Created attachment 130815 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-03-08 06:28:08 PST
Comment on attachment 130815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130815&action=review > Source/WebCore/CMakeLists.txt:1691 > LIST(APPEND WebCore_IDL_FILES > fileapi/FileException.idl > fileapi/OperationNotAllowedException.idl Could you please merge this block with another IF (ENABLE_BLOB) section we have in line 1455 now that the check is the same?
Mark Pilgrim (Google)
Comment 3 2012-03-08 07:53:17 PST
Created attachment 130821 [details] Patch with merged blocks
Adam Barth
Comment 4 2012-03-08 14:29:02 PST
Comment on attachment 130821 [details] Patch with merged blocks Thanks.
WebKit Review Bot
Comment 5 2012-03-08 16:41:38 PST
Comment on attachment 130821 [details] Patch with merged blocks Clearing flags on attachment: 130821 Committed r110231: <http://trac.webkit.org/changeset/110231>
WebKit Review Bot
Comment 6 2012-03-08 16:41:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.