Bug 80584

Summary: [chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status
Product: WebKit Reporter: Nat Duca <nduca>
Component: New BugsAssignee: Nat Duca <nduca>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
null check during initialize
none
Normalize SingleThreadProxy behavior also none

Nat Duca
Reported 2012-03-08 02:43:40 PST
[chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status
Attachments
Patch (3.21 KB, patch)
2012-03-08 02:44 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
null check during initialize (3.23 KB, patch)
2012-03-08 03:47 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Normalize SingleThreadProxy behavior also (4.04 KB, patch)
2012-03-08 14:30 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2012-03-08 02:44:12 PST
Created attachment 130799 [details] Patch
Nat Duca
Comment 2 2012-03-08 02:46:57 PST
As part of re-working the compositeAndReadback flow, I am trying to write a unit test that fails for the existing broken case. In doing that, I got bitten by the visibility call behaving differently during initialization. So, I'm thinking, can we just make it all the time?
Nat Duca
Comment 3 2012-03-08 03:47:14 PST
Created attachment 130804 [details] null check during initialize
James Robinson
Comment 4 2012-03-08 11:09:20 PST
Comment on attachment 130804 [details] null check during initialize View in context: https://bugs.webkit.org/attachment.cgi?id=130804&action=review OK > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:399 > + if (visible && m_layerRenderer && m_layerRenderer->capabilities().usingPartialSwap) since we're also null checking m_layerRenderer on line 394 probably better to just null check it and return above that line instead of checking it twice
Nat Duca
Comment 5 2012-03-08 14:30:23 PST
Created attachment 130907 [details] Normalize SingleThreadProxy behavior also
Nat Duca
Comment 6 2012-03-08 14:30:53 PST
Comment on attachment 130907 [details] Normalize SingleThreadProxy behavior also Putting r? again because I made a similar change to CCSingleThreadProxy::setVisible
James Robinson
Comment 7 2012-03-08 15:08:54 PST
Comment on attachment 130907 [details] Normalize SingleThreadProxy behavior also OK
WebKit Review Bot
Comment 8 2012-03-08 19:52:41 PST
Comment on attachment 130907 [details] Normalize SingleThreadProxy behavior also Clearing flags on attachment: 130907 Committed r110255: <http://trac.webkit.org/changeset/110255>
WebKit Review Bot
Comment 9 2012-03-08 19:52:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.