Bug 80565

Summary: [Chromium] Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled.
Product: WebKit Reporter: Ami Fischman <fischman>
Component: New BugsAssignee: Ami Fischman <fischman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, fischman, fishd, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ami Fischman
Reported 2012-03-07 21:09:12 PST
Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled.
Attachments
Patch (1.53 KB, patch)
2012-03-07 21:11 PST, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Patch (3.43 KB, patch)
2012-03-07 21:24 PST, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ami Fischman
Comment 1 2012-03-07 21:11:05 PST
Created attachment 130758 [details] Patch
James Robinson
Comment 2 2012-03-07 21:13:33 PST
Comment on attachment 130758 [details] Patch I should you should also update the various comments around this function (and the functions that call into this) to clearly document the expectations of this return value - i.e. you can't make any GL calls or make the context current unless you know you're on the thread the compositor is running on.
Ami Fischman
Comment 3 2012-03-07 21:24:36 PST
Created attachment 130762 [details] Patch
WebKit Review Bot
Comment 4 2012-03-07 21:25:54 PST
Please wait for approval from fishd@chromium.org, abarth@webkit.org or jamesr@chromium.org before submitting because this patch contains changes to the Chromium platform API.
James Robinson
Comment 5 2012-03-07 21:25:57 PST
Comment on attachment 130762 [details] Patch Cool, I think that's sufficiently scary.
WebKit Review Bot
Comment 6 2012-03-07 22:55:52 PST
Comment on attachment 130762 [details] Patch Clearing flags on attachment: 130762 Committed r110149: <http://trac.webkit.org/changeset/110149>
WebKit Review Bot
Comment 7 2012-03-07 22:55:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.