Bug 80555

Summary: IndexedDB: layout test style update
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

David Grogan
Reported 2012-03-07 17:36:44 PST
IndexedDB: layout test style update
Attachments
Patch (110.26 KB, patch)
2012-03-07 17:41 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (110.39 KB, patch)
2012-03-07 17:51 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (117.47 KB, patch)
2012-03-08 15:36 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (117.94 KB, patch)
2012-03-08 15:43 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-03-07 17:41:42 PST
Created attachment 130735 [details] Patch
David Grogan
Comment 2 2012-03-07 17:51:05 PST
Created attachment 130739 [details] Patch
David Grogan
Comment 3 2012-03-07 18:01:47 PST
Josh, can you take a look at this? There are only two -expected.txt changes, both for js line numbers. Next patch is going to move all the indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;"); shouldBeFalse("indexedDB == null"); IDBDatabaseException = evalAndLog("IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;"); ... lines to a function in shared.js that uses self instead of window.
Joshua Bell
Comment 4 2012-03-08 13:51:49 PST
Comment on attachment 130739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130739&action=review > LayoutTests/storage/indexeddb/mozilla/autoincrement-indexes.html:89 > function checkThirdIndex() this file still has the if (window.layoutTestController) ... preamble - needed? > LayoutTests/storage/indexeddb/mozilla/bad-keypath.html:55 > function addFirstSuccess() ditto - if (window.layoutTestController) ... Was it accidentally left in the mozilla/ tests, or is it needed for some reason?
David Grogan
Comment 5 2012-03-08 15:36:47 PST
Created attachment 130922 [details] Patch
David Grogan
Comment 6 2012-03-08 15:38:10 PST
> ditto - if (window.layoutTestController) ... > > Was it accidentally left in the mozilla/ tests, or is it needed for some reason? Accident - fixed.
David Grogan
Comment 7 2012-03-08 15:43:45 PST
Created attachment 130924 [details] Patch Deleted few more stray lines
Joshua Bell
Comment 8 2012-03-08 16:13:49 PST
Comment on attachment 130924 [details] Patch lgtm
David Grogan
Comment 9 2012-03-08 18:25:21 PST
Tony, could you review this?
Tony Chang
Comment 10 2012-03-12 09:26:16 PDT
Comment on attachment 130924 [details] Patch rs=me
WebKit Review Bot
Comment 11 2012-03-12 13:26:44 PDT
Comment on attachment 130924 [details] Patch Clearing flags on attachment: 130924 Committed r110468: <http://trac.webkit.org/changeset/110468>
WebKit Review Bot
Comment 12 2012-03-12 13:26:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.