Bug 8055

Summary: Fix most CSS grammar conflicts
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: CSSAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 6380    
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2006-03-29 08:27:32 PST
Bison currently reports 37+4 shift/reduce and reduce/reduce conflicts, this patch gets the number down to 7+0. I have fixed the reduce/reduce conflicts, then noticed that two of the fixes were already made in KDE tree (the other two are different because declaration blocks are described in quite different ways). Shift/reduce fixes are just merged from KDE, r332845 by Michael Matz.
Attachments
proposed patch (6.17 KB, patch)
2006-03-29 08:29 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-03-29 08:29:10 PST
Created attachment 7373 [details] proposed patch
Darin Adler
Comment 2 2006-03-29 08:39:45 PST
Comment on attachment 7373 [details] proposed patch It's a little strange to give a space and a selector the same precedence as the "unimportant" token. I see that it might work, but it seems a bit obscure or subtle. But that's a nitpick. This change looks great! r=me
Alexey Proskuryakov
Comment 3 2006-03-29 09:35:22 PST
(In reply to comment #2) The precedence changes are only needed for shift/reduce fixes, taken from KDE. I cannot say that I understood them particularly well. Landed, r13560.
Note You need to log in before you can comment on or make changes to this bug.