Bug 80541

Summary:

Implement getAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap

Product:

WebKit

Reporter:

Caio Marcelo de Oliveira Filho <cmarcelo>

Component:

New Bugs

Assignee:

Caio Marcelo de Oliveira Filho <cmarcelo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

75069

Attachments:

Description	Flags
Patch	rniwa: review+

Description Caio Marcelo de Oliveira Filho 2012-03-07 14:22:08 PST

Implement getAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap

Comment 1 Caio Marcelo de Oliveira Filho 2012-03-07 14:27:39 PST

Created attachment 130693 [details]
Patch

Comment 2 Ryosuke Niwa 2012-03-07 15:32:46 PST

Comment on attachment 130693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130693&action=review

> Source/WebCore/dom/ElementAttributeData.h:159
> +    Attribute* a = getAttributeItem(name, shouldIgnoreAttributeCase);

Please don't use one-letter abbreviations like "a". Instead, spell-out attribute.

> Source/WebCore/dom/ElementAttributeData.h:168
> +    Attribute* a = getAttributeItem(name);

Ditto.

Comment 3 Caio Marcelo de Oliveira Filho 2012-03-07 15:58:08 PST

Committed r110119: <http://trac.webkit.org/changeset/110119>