Bug 80541

Summary: Implement getAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75069    
Attachments:
Description Flags
Patch rniwa: review+

Caio Marcelo de Oliveira Filho
Reported 2012-03-07 14:22:08 PST
Implement getAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Attachments
Patch (7.73 KB, patch)
2012-03-07 14:27 PST, Caio Marcelo de Oliveira Filho 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2012-03-07 14:27:39 PST
Created attachment 130693 [details] Patch
Ryosuke Niwa
Comment 2 2012-03-07 15:32:46 PST
Comment on attachment 130693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130693&action=review > Source/WebCore/dom/ElementAttributeData.h:159 > + Attribute* a = getAttributeItem(name, shouldIgnoreAttributeCase); Please don't use one-letter abbreviations like "a". Instead, spell-out attribute. > Source/WebCore/dom/ElementAttributeData.h:168 > + Attribute* a = getAttributeItem(name); Ditto.
Caio Marcelo de Oliveira Filho
Comment 3 2012-03-07 15:58:08 PST
Committed r110119: <http://trac.webkit.org/changeset/110119>
Note You need to log in before you can comment on or make changes to this bug.