Bug 80522

Summary: Implement removeAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75069    
Attachments:
Description Flags
Patch kling: review+

Caio Marcelo de Oliveira Filho
Reported 2012-03-07 11:00:05 PST
Implement removeAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Attachments
Patch (7.64 KB, patch)
2012-03-07 11:07 PST, Caio Marcelo de Oliveira Filho 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2012-03-07 11:07:50 PST
Created attachment 130651 [details] Patch
Andreas Kling
Comment 2 2012-03-07 11:26:10 PST
Comment on attachment 130651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130651&action=review r=me > Source/WebCore/dom/Element.cpp:192 > if (!m_attributeMap) > return; > > - m_attributeMap->removeAttribute(name); > + m_attributeMap->attributeData()->removeAttribute(name, this); You could bypass m_attributeMap entirely here and just use Element::attributeData().
Caio Marcelo de Oliveira Filho
Comment 3 2012-03-07 12:38:04 PST
Committed r110086: <http://trac.webkit.org/changeset/110086>
Note You need to log in before you can comment on or make changes to this bug.