Bug 80501 – Remove Node::isContentElement and Node::isShadowElement

• Component: DOM
• Status: RESOLVED FIXED

[Shinya Kawanaka]

We can remove these methods to use isInsertionPoint.

[Shinya Kawanaka]

Created attachment 130585 [details]
Patch

[Build Bot]

Comment on attachment 130585 [details]
Patch

Attachment 130585 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11833954

[Shinya Kawanaka]

Ah, symbols are necessary? I'll add them after EWS building windows port.

[WebKit Review Bot]

Comment on attachment 130585 [details]
Patch

Attachment 130585 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11850020

New failing tests:
fast/dom/shadow/content-element-user-agent-shadow.html

[Gustavo Noronha (kov)]

Comment on attachment 130585 [details]
Patch

Attachment 130585 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11839973

[Dimitri Glazkov (Google)]

Comment on attachment 130585 [details]
Patch

Looks great! please fix the build failures before landing.

[Shinya Kawanaka]

Created attachment 130747 [details]
Build test

[Shinya Kawanaka]

I found this approach is very difficult now.
We have RuntimeEnabledFeatures::shadowDOMEnabled() now, and the tagName of <content> is changed by the flag...

[Shinya Kawanaka]

(In reply to comment #8)
> I found this approach is very difficult now.
> We have RuntimeEnabledFeatures::shadowDOMEnabled() now, and the tagName of <content> is changed by the flag...

I found I was wrong...
The content elements in <details> and <summary> should always have HTMLNames::webkitShadowContentTag.

[Shinya Kawanaka]

Created attachment 130766 [details]
Patch

[Build Bot]

Comment on attachment 130766 [details]
Patch

Attachment 130766 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11863164

[Shinya Kawanaka]

Created attachment 130773 [details]
Patch

[Shinya Kawanaka]

Created attachment 130776 [details]
Patch

[Shinya Kawanaka]

Created attachment 130777 [details]
Patch

[Hajime Morrita]

Comment on attachment 130777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130777&action=review

> Source/WebCore/html/shadow/InsertionPoint.h:54
> +    virtual bool isInsertionPoint() const { return true; }

OVERRIDE here.

> Source/WebCore/html/shadow/InsertionPoint.h:77
> +    // https://bugs.webkit.org/show_bug.cgi?id=78596

It looks we don't need something special for <shadow>.

[Shinya Kawanaka]

Created attachment 130780 [details]
Patch

[Shinya Kawanaka]

(In reply to comment #16)
> Created an attachment (id=130780) [details]
> Patch

(In reply to comment #15)
> (From update of attachment 130777 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130777&action=review
> 
> > Source/WebCore/html/shadow/InsertionPoint.h:54
> > +    virtual bool isInsertionPoint() const { return true; }
> 
> OVERRIDE here.

Done.

> 
> > Source/WebCore/html/shadow/InsertionPoint.h:77
> > +    // https://bugs.webkit.org/show_bug.cgi?id=78596
> 
> It looks we don't need something special for <shadow>.

Done.

[Hajime Morrita]

Comment on attachment 130780 [details]
Patch

Looks OK.

[Shinya Kawanaka]

Committed r110151: <http://trac.webkit.org/changeset/110151>