Bug 80493

Summary: Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth()
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, hans, morrita, satish, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80479    
Attachments:
Description Flags
Patch
none
Patch 2 morrita: review+, morrita: commit-queue-

Kent Tamura
Reported 2012-03-06 22:55:16 PST
Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth()
Attachments
Patch (11.01 KB, patch)
2012-03-06 23:15 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (11.87 KB, patch)
2012-03-07 05:18 PST, Kent Tamura 		morrita: review+
morrita: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-03-06 23:15:42 PST
Created attachment 130551 [details] Patch
WebKit Review Bot
Comment 2 2012-03-07 02:19:38 PST
Comment on attachment 130551 [details] Patch Attachment 130551 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11838879
Kent Tamura
Comment 3 2012-03-07 05:18:27 PST
Created attachment 130602 [details] Patch 2 Chromium build fix
Hajime Morrita
Comment 4 2012-03-07 18:03:56 PST
Comment on attachment 130602 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=130602&action=review Looks good. My guess is that there is more code like this which was used a source of this change.... > Source/WebCore/ChangeLog:13 > + The default borders and paddings of these buttons are 0, this code was Want some conjunction here to clarify the connection.
Kent Tamura
Comment 5 2012-03-07 19:01:17 PST
(In reply to comment #4) > > + The default borders and paddings of these buttons are 0, this code was > > Want some conjunction here to clarify the connection. I updated ChangeLog, and am landing.
Kent Tamura
Comment 6 2012-03-07 19:03:04 PST
Committed r110130: <http://trac.webkit.org/changeset/110130>
Note You need to log in before you can comment on or make changes to this bug.