| Summary: | Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
| Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, hans, morrita, satish, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 80479 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kent Tamura
2012-03-06 22:55:16 PST
Created attachment 130551 [details]
Patch
Comment on attachment 130551 [details] Patch Attachment 130551 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11838879 Created attachment 130602 [details]
Patch 2
Chromium build fix
Comment on attachment 130602 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=130602&action=review Looks good. My guess is that there is more code like this which was used a source of this change.... > Source/WebCore/ChangeLog:13 > + The default borders and paddings of these buttons are 0, this code was Want some conjunction here to clarify the connection. (In reply to comment #4) > > + The default borders and paddings of these buttons are 0, this code was > > Want some conjunction here to clarify the connection. I updated ChangeLog, and am landing. Committed r110130: <http://trac.webkit.org/changeset/110130> |