Bug 80473
| Summary: | check-webkit-style should warn about "XCode" vs "Xcode" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | mrowe, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Eric Seidel (no email)
check-webkit-style should warn about "XCode" vs "Xcode"
Everyone gets it wrong. And reviewers shouldn't have to notice this sort of thing. :)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Rowe (bdash)
OSX vs OS X would be another good one to catch too.
Eric Seidel (no email)
My belief is that if reviewers are going to comment on these things (I'm personally agnostic), than we should make the tools worry about it, instead of reviewers. That theoretically allows reviewers to only have to worry about the important stuff.
We should add a couple of these, and see how we feel. It should be super easy to generalize. Gtk and Qt reviewers might be commenting on capitalization of those as well (I don't know). If that's the case, we should make the tools complain about the ones we care about and (hopefully) ignore the rest. :)