Bug 80469

Summary:

[CMake] Make the removal of transitive library dependencies work with CMake < 2.8.7.

Product:

WebKit

Reporter:

Raphael Kubo da Costa (:rakuco) <rakuco>

Component:

New Bugs

Assignee:

Raphael Kubo da Costa (:rakuco) <rakuco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, kevin.cs.oh, mxie, paroga, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Description Raphael Kubo da Costa (:rakuco) 2012-03-06 18:32:37 PST

Sorry, but I had not noticed the CMAKE_LINK_INTERFACE_LIBRARIES variable I use in r109983 was introduced in CMake 2.8.7, so the build is still broken on popular distros which have earlier CMake versions (at least Ubuntu and Fedora, I guess). For now, we need to manually set the LINK_INTERFACE_LIBRARIES property on each target.

Comment 1 Raphael Kubo da Costa (:rakuco) 2012-03-06 18:36:31 PST

Created attachment 130515 [details]
Proposed patch

Comment 2 Antonio Gomes 2012-03-06 19:27:39 PST

Comment on attachment 130515 [details]
Proposed patch

ok

Comment 3 WebKit Review Bot 2012-03-06 23:37:36 PST

Comment on attachment 130515 [details]
Proposed patch

Clearing flags on attachment: 130515

Committed r110024: <http://trac.webkit.org/changeset/110024>

Comment 4 WebKit Review Bot 2012-03-06 23:37:40 PST

All reviewed patches have been landed.  Closing bug.