Bug 80464

Summary: [chromium] Support printing WebGL content in threaded compositor
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, kbr, nduca, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80459    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

James Robinson
Reported 2012-03-06 17:40:41 PST
[chromium] Support printing WebGL content in threaded compositor
Attachments
Patch (3.65 KB, patch)
2012-03-06 17:42 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (4.72 KB, patch)
2012-03-07 13:25 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-03-06 17:42:24 PST
Created attachment 130496 [details] Patch
James Robinson
Comment 2 2012-03-07 13:25:10 PST
Created attachment 130681 [details] Patch
James Robinson
Comment 3 2012-03-07 13:25:50 PST
Updated to ToT. I've confirmed manually that printing and lost context recovery work for WebGL content in threaded mode.
Kenneth Russell
Comment 4 2012-03-07 14:02:09 PST
Comment on attachment 130681 [details] Patch Fantastic. Thanks for taking care of this. r=me
Adrienne Walker
Comment 5 2012-03-07 14:19:22 PST
Comment on attachment 130681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130681&action=review > Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:111 > + if (m_textureUpdated || !m_drawingBuffer || !drawsContent()) Shouldn't this be context()? Can't m_drawingBuffer->graphicsContext3D() be potentially null?
James Robinson
Comment 6 2012-03-07 14:21:11 PST
Looking at WebGLLayerChromium::setDrawingBuffer() it looks like a non-NULL DrawingBuffer with a NULL DrawingBuffer::graphicsContext3D() is not a valid state for this code.
WebKit Review Bot
Comment 7 2012-03-07 15:55:55 PST
Comment on attachment 130681 [details] Patch Clearing flags on attachment: 130681 Committed r110118: <http://trac.webkit.org/changeset/110118>
WebKit Review Bot
Comment 8 2012-03-07 15:56:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.