Bug 80457

Summary: Further harden 64-bit JIT
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch fpizlo: review+

Oliver Hunt
Reported 2012-03-06 17:13:42 PST
Further harden 64-bit JIT
Attachments
Patch (51.55 KB, patch)
2012-03-06 17:17 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (51.91 KB, patch)
2012-03-06 17:43 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (51.86 KB, patch)
2012-03-07 16:54 PST, Oliver Hunt 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2012-03-06 17:17:35 PST
Created attachment 130483 [details] Patch
WebKit Review Bot
Comment 2 2012-03-06 17:23:57 PST
Attachment 130483 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:645: xorq_rm is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/assembler/X86Assembler.h:650: rorq_i8r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-03-06 17:25:58 PST
Comment on attachment 130483 [details] Patch Attachment 130483 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11838628
Oliver Hunt
Comment 4 2012-03-06 17:43:11 PST
Created attachment 130497 [details] Patch
WebKit Review Bot
Comment 5 2012-03-06 17:46:23 PST
Attachment 130497 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:645: xorq_rm is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/assembler/X86Assembler.h:650: rorq_i8r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 6 2012-03-06 17:56:53 PST
Comment on attachment 130497 [details] Patch Attachment 130497 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11836646
Early Warning System Bot
Comment 7 2012-03-07 15:37:09 PST
Comment on attachment 130497 [details] Patch Attachment 130497 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/11843002
Oliver Hunt
Comment 8 2012-03-07 16:54:01 PST
Created attachment 130727 [details] Patch
WebKit Review Bot
Comment 9 2012-03-07 16:57:41 PST
Attachment 130727 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:645: xorq_rm is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/assembler/X86Assembler.h:650: rorq_i8r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 10 2012-03-07 16:58:39 PST
Comment on attachment 130727 [details] Patch r=me!
Oliver Hunt
Comment 11 2012-03-07 17:07:50 PST
Committed r110122: <http://trac.webkit.org/changeset/110122>
Note You need to log in before you can comment on or make changes to this bug.