Bug 80452

Summary: Cleanup incDOMTreeVersion callers
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adamk, ap, darin, eric, kling, koivisto, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Removed redundant calls to incDOMTreeVersion kling: review+

Ryosuke Niwa
Reported 2012-03-06 16:28:43 PST
Cleanup incDOMTreeVersion callers
Attachments
Patch (11.73 KB, patch)
2012-03-06 16:32 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed redundant calls to incDOMTreeVersion (11.50 KB, patch)
2012-03-06 16:39 PST, Ryosuke Niwa 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-03-06 16:32:38 PST
Created attachment 130469 [details] Patch
Ryosuke Niwa
Comment 2 2012-03-06 16:39:06 PST
Created attachment 130470 [details] Removed redundant calls to incDOMTreeVersion
Adam Klein
Comment 3 2012-03-06 17:08:37 PST
Comment on attachment 130470 [details] Removed redundant calls to incDOMTreeVersion View in context: https://bugs.webkit.org/attachment.cgi?id=130470&action=review > Source/WebCore/dom/CharacterData.cpp:84 > + document()->incDOMTreeVersion(); As discussed, this line is unnecessary. If you really want it for consistency, you can leave it, but it's strictly redundant.
Ryosuke Niwa
Comment 4 2012-03-07 11:45:27 PST
Any reviewers?
Ryosuke Niwa
Comment 5 2012-03-09 12:34:22 PST
Committed r110320: <http://trac.webkit.org/changeset/110320>
Note You need to log in before you can comment on or make changes to this bug.