Bug 80452 - Cleanup incDOMTreeVersion callers
Summary: Cleanup incDOMTreeVersion callers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 16:28 PST by Ryosuke Niwa
Modified: 2012-03-09 12:34 PST (History)
9 users (show)

See Also:

Attachments
Patch (11.73 KB, patch)
2012-03-06 16:32 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Removed redundant calls to incDOMTreeVersion (11.50 KB, patch)
2012-03-06 16:39 PST, Ryosuke Niwa 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-06 16:28:43 PST 
Cleanup incDOMTreeVersion callers
Comment 1 Ryosuke Niwa 2012-03-06 16:32:38 PST 
Created attachment 130469 [details]
Patch
Comment 2 Ryosuke Niwa 2012-03-06 16:39:06 PST 
Created attachment 130470 [details]
Removed redundant calls to incDOMTreeVersion
Comment 3 Adam Klein 2012-03-06 17:08:37 PST 
Comment on attachment 130470 [details]
Removed redundant calls to incDOMTreeVersion

View in context: https://bugs.webkit.org/attachment.cgi?id=130470&action=review

> Source/WebCore/dom/CharacterData.cpp:84
> +    document()->incDOMTreeVersion();

As discussed, this line is unnecessary. If you really want it for consistency, you can leave it, but it's strictly redundant.
Comment 4 Ryosuke Niwa 2012-03-07 11:45:27 PST 
Any reviewers?
Comment 5 Ryosuke Niwa 2012-03-09 12:34:22 PST 
Committed r110320: <http://trac.webkit.org/changeset/110320>