Bug 80412

Summary: Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Description Pavel Podivilov 2012-03-06 05:50:42 PST 
Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
Comment 1 Pavel Podivilov 2012-03-06 05:53:02 PST 
Created attachment 130365 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-06 08:03:23 PST 
Comment on attachment 130365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130365&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-33
> - * @extends {WebInspector.ScriptMapping}

Let's keep ScriptMapping interface implemented by DebuggerPresentationModel to be used by external clients (uiLocationToRawLocation(), rawLocationToUILocation() etc.). Beside that we can have a MutableScriptMapping interface with addScript() and reset() methods to be implemented by MainScriptMapping and other helper script mappings inside MainScriptMapping.
Comment 3 Pavel Podivilov 2012-03-07 02:08:14 PST 
Created attachment 130574 [details]
Patch
Comment 4 Pavel Podivilov 2012-03-07 02:55:26 PST 
Committed r110043: <http://trac.webkit.org/changeset/110043>