Speech JavaScript API: add SpeechRecognitionError

• Component: New Bugs
• Status: RESOLVED FIXED

[Hans Wennborg]

Speech JavaScript API: add SpeechRecognitionError

[Hans Wennborg]

Created attachment 130366 [details]
Patch

[Hans Wennborg]

Created attachment 130369 [details]
Patch

Rebase

[Satish Sampath]

Comment on attachment 130369 [details]
Patch

> Source/WebCore/Modules/speech/SpeechRecognitionError.h: 52
> Kind code() { return m_kind; }

Should the type be named as 'Code' and the variable m_code so that this getter actually gets the parameter with that name?

> LayoutTests/fast/speech/scripted/speechrecognitionerror-basics.html: 12
> shouldBeTrue("'webkitSpeechRecognitionError' in self");

using 'self' works here but perhaps it would be clearer to use 'window' instead?

[Hans Wennborg]

(In reply to comment #3)
> (From update of attachment 130369 [details])
> > Source/WebCore/Modules/speech/SpeechRecognitionError.h: 52
> > Kind code() { return m_kind; }
> 
> Should the type be named as 'Code' and the variable m_code so that this getter actually gets the parameter with that name?

Done.

> 
> > LayoutTests/fast/speech/scripted/speechrecognitionerror-basics.html: 12
> > shouldBeTrue("'webkitSpeechRecognitionError' in self");
> 
> using 'self' works here but perhaps it would be clearer to use 'window' instead?

Done.

[Hans Wennborg]

Created attachment 130381 [details]
Patch

[Satish Sampath]

looks good to me

[Adam Barth]

Comment on attachment 130381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130381&action=review

Looks great.  Thanks!

> Source/WebCore/ChangeLog:8
> +        Add SpeechRecognitionError.

Can you add a link to the spec?  That will help folks who look at this change later.

[Adam Barth]

> Can you add a link to the spec?  That will help folks who look at this change later.

Please feel free to ignore this comment on this change, but for the upcoming changes, it would be nice to link to the spec.

[WebKit Review Bot]

Comment on attachment 130381 [details]
Patch

Clearing flags on attachment: 130381

Committed r109938: <http://trac.webkit.org/changeset/109938>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.