[Shadow DOM] Extends path notation used in test utility function so that we can specify arbitrary ShadowRoot in Shadow Tree.

• Component: DOM
• Status: RESOLVED FIXED

[Hayato Ito]

Some layout tests (in fast/dom/shadow) use a 'getElementByIdInShadow(path)' utility function, which does not support getting an element in arbitrary ShadowRoot.
We can get an element only from the youngest ShadowRoot by the current path notation.

It'd be nice to get an element from arbitrary ShadowRoot in ShadowTree, extending path notation.

[Hayato Ito]

Created attachment 130353 [details]
support multiple shadowroots notation

[Dimitri Glazkov (Google)]

Comment on attachment 130353 [details]
support multiple shadowroots notation

View in context: https://bugs.webkit.org/attachment.cgi?id=130353&action=review

> LayoutTests/fast/dom/shadow/resources/shadow-dom.js:38
> +function getElementInShadowTree(path)

ShadowTreeStack maybe?

[Hayato Ito]

Thank you for the review.

(In reply to comment #2)
> (From update of attachment 130353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130353&action=review
> 
> > LayoutTests/fast/dom/shadow/resources/shadow-dom.js:38
> > +function getElementInShadowTree(path)
> 
> ShadowTreeStack maybe?


Okay. Let me rename that. I'll land this patch after renaming.

[Hayato Ito]

Created attachment 130501 [details]
Patch for landing

[Hayato Ito]

Let me merge this patch with http://trac.webkit.org/changeset/109967.

[Hayato Ito]

Created attachment 130510 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 130510 [details]
Patch for landing

Clearing flags on attachment: 130510

Committed r110022: <http://trac.webkit.org/changeset/110022>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.