Bug 80404

Summary: r109563 caused perf regression
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: CSSAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, koivisto, macpherson, menard, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Roland Steiner
Reported 2012-03-06 02:46:30 PST
The culprit is one line in CSSStyleSelector::pushParentElement(): changing from parentOrHostElement() to parentOrHostNode(), causing a 20% perf regression in Parser/html5-full-render.html.
Attachments
Patch (1.79 KB, patch)
2012-03-06 02:49 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2012-03-06 03:19 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2012-03-06 02:49:38 PST
Created attachment 130346 [details] Patch
Roland Steiner
Comment 2 2012-03-06 03:19:37 PST
Created attachment 130348 [details] Patch
WebKit Review Bot
Comment 3 2012-03-06 04:43:11 PST
Comment on attachment 130348 [details] Patch Clearing flags on attachment: 130348 Committed r109906: <http://trac.webkit.org/changeset/109906>
WebKit Review Bot
Comment 4 2012-03-06 04:43:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.