Bug 80395

Summary: Web Inspector: remove reference to RawSourceCode from UISourceCode.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Pavel Podivilov
Reported 2012-03-06 00:54:21 PST
Web Inspector: remove reference to RawSourceCode from UISourceCode.
Attachments
Patch (15.84 KB, patch)
2012-03-06 00:57 PST, Pavel Podivilov 		vsevik: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2012-03-06 00:57:08 PST
Created attachment 130325 [details] Patch
Vsevolod Vlasov
Comment 2 2012-03-06 02:01:03 PST
Comment on attachment 130325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130325&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:217 > + for (var i = 0; i < addedItems.length; ++i) We should probably process removedItems first and then addedItems. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274 > + var script = WebInspector.debuggerModel.scriptForSourceID(rawLocation.scriptId); Do you need script at all? Looks like scriptId is enough.
Pavel Podivilov
Comment 3 2012-03-06 03:55:22 PST
Comment on attachment 130325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130325&action=review >> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:217 >> + for (var i = 0; i < addedItems.length; ++i) > > We should probably process removedItems first and then addedItems. Done. >> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274 >> + var script = WebInspector.debuggerModel.scriptForSourceID(rawLocation.scriptId); > > Do you need script at all? Looks like scriptId is enough. I think it should actually be "WebInspector.resourceForURL(script.sourceURL)" below. So I better keep the script.
Pavel Podivilov
Comment 4 2012-03-06 04:12:12 PST
Committed r109899: <http://trac.webkit.org/changeset/109899>
Note You need to log in before you can comment on or make changes to this bug.