Bug 80379

Summary: CSS3 calc: rewrite margin test to use getComputedStyle
Product: WebKit Reporter: Mike Lawther <mikelawther>
Component: New BugsAssignee: Mike Lawther <mikelawther>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 16662    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Mike Lawther
Reported 2012-03-05 22:18:57 PST
CSS3 calc: rewrite margin test to use pre/post js
Attachments
Patch (11.87 KB, patch)
2012-03-05 22:20 PST, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch (11.88 KB, patch)
2012-03-05 22:27 PST, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.67 KB, patch)
2012-03-05 22:45 PST, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mike Lawther
Comment 1 2012-03-05 22:20:24 PST
Created attachment 130292 [details] Patch
Mike Lawther
Comment 2 2012-03-05 22:27:48 PST
Created attachment 130293 [details] Patch
Kent Tamura
Comment 3 2012-03-05 22:35:51 PST
Comment on attachment 130293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130293&action=review > LayoutTests/css3/calc/margin-expected.txt:2 > +PASS getComputedStyle(document.getElementById("simple-all"), null).marginLeft is "25px" > +PASS getComputedStyle(document.getElementById("simple-all"), null).marginTop is "25px" nit: The result looks too busy. We can simplify it by adding functions. e.g. computedMarginLeft("simple-all") computedMarginTop("simple-all") ...
Mike Lawther
Comment 4 2012-03-05 22:44:27 PST
> nit: The result looks too busy. We can simplify it by adding functions. e.g. > computedMarginLeft("simple-all") > computedMarginTop("simple-all") Good idea - done.
Mike Lawther
Comment 5 2012-03-05 22:45:05 PST
Created attachment 130297 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-03-06 01:06:52 PST
Comment on attachment 130297 [details] Patch for landing Clearing flags on attachment: 130297 Committed r109874: <http://trac.webkit.org/changeset/109874>
WebKit Review Bot
Comment 7 2012-03-06 01:06:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.