Bug 80379

Summary: CSS3 calc: rewrite margin test to use getComputedStyle
Product: WebKit Reporter: Mike Lawther <mikelawther>
Component: New BugsAssignee: Mike Lawther <mikelawther>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 16662    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Mike Lawther 2012-03-05 22:18:57 PST 
CSS3 calc: rewrite margin test to use pre/post js
Comment 1 Mike Lawther 2012-03-05 22:20:24 PST 
Created attachment 130292 [details]
Patch
Comment 2 Mike Lawther 2012-03-05 22:27:48 PST 
Created attachment 130293 [details]
Patch
Comment 3 Kent Tamura 2012-03-05 22:35:51 PST 
Comment on attachment 130293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130293&action=review

> LayoutTests/css3/calc/margin-expected.txt:2
> +PASS getComputedStyle(document.getElementById("simple-all"), null).marginLeft is "25px"
> +PASS getComputedStyle(document.getElementById("simple-all"), null).marginTop is "25px"

nit: The result looks too busy. We can simplify it by adding functions.  e.g.
 computedMarginLeft("simple-all")
 computedMarginTop("simple-all")
 ...
Comment 4 Mike Lawther 2012-03-05 22:44:27 PST 
> nit: The result looks too busy. We can simplify it by adding functions.  e.g.
>  computedMarginLeft("simple-all")
>  computedMarginTop("simple-all")

Good idea - done.
Comment 5 Mike Lawther 2012-03-05 22:45:05 PST 
Created attachment 130297 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-03-06 01:06:52 PST 
Comment on attachment 130297 [details]
Patch for landing

Clearing flags on attachment: 130297

Committed r109874: <http://trac.webkit.org/changeset/109874>
Comment 7 WebKit Review Bot 2012-03-06 01:06:56 PST 
All reviewed patches have been landed.  Closing bug.