Bug 80377

Summary: [BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream
Product: WebKit Reporter: Jonathan Dong <jonathan.dong.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, leoyang.webkit, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Dong
Reported 2012-03-05 22:18:51 PST
As some of the function names changed in class MediaPlayerPrivate with the upstream of MediaPlayerPrivateBlackBerry.[cpp|h], we should update WebKit/blackberry/Api/WebPage.cpp which uses these functions accordingly. renamed functions in MediaPlayerPrivate: windowGet() -> getWindow() windowPositionGet() -> getWindowPosition() mmrContextNameGet() -> mmrContextName()
Attachments
Patch (2.10 KB, patch)
2012-03-05 22:28 PST, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Dong
Comment 1 2012-03-05 22:28:30 PST
Created attachment 130294 [details] Patch
Rob Buis
Comment 2 2012-03-06 04:41:39 PST
Comment on attachment 130294 [details] Patch LGTM. But maybe window() instead of windowGet(), this would be more webkit style.
WebKit Review Bot
Comment 3 2012-03-06 04:59:53 PST
Comment on attachment 130294 [details] Patch Clearing flags on attachment: 130294 Committed r109907: <http://trac.webkit.org/changeset/109907>
WebKit Review Bot
Comment 4 2012-03-06 04:59:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.